refactor(api): adopt @octokit/types
#2525
Merged
+61
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <[email protected]>
github-actions
bot
added
dependency
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
setchy
commented
Jan 20, 2026
|
|
||
| export type NotificationThreadSubscription = | ||
| components['schemas']['thread-subscription']; | ||
| export type ListNotificationsForAuthenticatedUserResponse = |
Member
Author
There was a problem hiding this comment.
More explicit use of GitHub REST HTTP verb and path to its response types
Signed-off-by: Adam Setch <[email protected]>
setchy
commented
Jan 20, 2026
| */ | ||
| export async function getHtmlUrl(url: Link, token: Token): Promise<string> { | ||
| try { | ||
| // TODO - Add explicit type for response shape |
Member
Author
There was a problem hiding this comment.
Added a TODO which I intend to clean up via #2545
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from the lower-level OAS types from https://github.com/octokit/openapi-types.ts to the REST endpoint types from https://github.com/octokit/types.ts.